fix(state): add missing thread lock to session_count() and message_count() - #2288
Closed
Mibayy wants to merge 1 commit into
Closed
fix(state): add missing thread lock to session_count() and message_count()#2288Mibayy wants to merge 1 commit into
Mibayy wants to merge 1 commit into
Conversation
…unt() Both methods accessed self._conn without self._lock, breaking the thread-safety contract documented on SessionDB (line 111). All 22 other DB methods use with self._lock — these two were the only exceptions. In the gateway's multi-threaded environment (multiple platform reader threads + single writer) this could cause cursor interleaving, sqlite3.ProgrammingError, or inconsistent COUNT results. Closes NousResearch#2130
Contributor
|
Merged via PR #2466 — cherry-picked with authorship preserved. Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_count()andmessage_count()inSessionDBwere accessingself._connwithout holdingself._lock, breaking the thread-safety guarantee documented on the class.Problem
SessionDBdocstring (line 111) explicitly states:All 22 other database-accessing methods wrap their operations in
with self._lock:. These two were the only exceptions.In the gateway's multi-threaded environment (platform reader threads + writer thread), the race condition can cause:
sqlite3.ProgrammingErroron concurrent connection accessCOUNT(*)resultsFix
Wrap both methods with
with self._lock:, identical to every other method in the class.Changes
hermes_state.pylines 856–874: addwith self._lock:tosession_count()andmessage_count()Closes #2130