fix(state): add missing thread lock to session_count() and message_count() - #2131
Closed
nidhi-singh02 wants to merge 1 commit into
Closed
Conversation
…unt() SessionDB promises thread-safety but these two methods accessed self._conn without self._lock, unlike all 22 other database methods in the class. Fixes NousResearch#2130 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Closing — duplicate of another open PR addressing the same issue. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionDB.session_count()andSessionDB.message_count()accessedself._connwithoutself._lock, unlike all 22 other database methods in the classwith self._lock:to match the existing thread-safety patternContext
The class docstring promises: "Thread-safe for the common gateway pattern (multiple reader threads, single writer via WAL mode)." These two utility methods were the only ones missing the lock, creating a race condition risk in the gateway's multi-threaded environment.
Test plan
session_count()andmessage_count()still return correct resultsFixes #2130
🤖 Generated with Claude Code