Skip to content

fix(doctor): skip /models health check for providers that don't support it - #21785

Closed
jak983464779 wants to merge 1 commit into
NousResearch:mainfrom
jak983464779:fix/doctor-xiaomi-health-check
Closed

fix(doctor): skip /models health check for providers that don't support it#21785
jak983464779 wants to merge 1 commit into
NousResearch:mainfrom
jak983464779:fix/doctor-xiaomi-health-check

Conversation

@jak983464779

Copy link
Copy Markdown
Contributor

Problem

Xiaomi MiMo's /v1/models endpoint returns 401 even with a valid API key, causing hermes doctor to falsely report "invalid API key".

This isn't unique to Xiaomi — any provider whose /models endpoint doesn't support auth verification will trigger the same false positive.

Solution

3 files, 4 lines added:

  1. providers/base.py — Add supports_health_check: bool = True field to ProviderProfile. Providers that don't support /models for auth verification can set it to False.

  2. hermes_cli/doctor.py — Dynamic provider discovery now reads supports_health_check from the profile instead of hardcoding True.

  3. plugins/model-providers/xiaomi/__init__.py — Set supports_health_check=False for Xiaomi MiMo.

Before and After

# Before
✗ xiaomi               (invalid API key)
Found 2 issue(s) to address

# After  
✓ xiaomi               (key configured)
Found 1 issue(s) to address

Testing

  • Verified hermes doctor no longer reports false positive for Xiaomi
  • Existing providers with supports_health_check=True (default) are unaffected

…rt it

Xiaomi MiMo's /v1/models endpoint returns 401 even with a valid API key,
causing hermes doctor to falsely report 'invalid API key'.

Add a `supports_health_check` field to ProviderProfile (default True).
Providers whose /models endpoint doesn't support auth verification can
set it to False. The doctor's dynamic provider discovery now reads this
field instead of hardcoding True.

The xiaomi provider plugin sets supports_health_check=False.
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #24657 (cherry-picked onto current main with your authorship preserved). Thanks for the contribution!

@teknium1 teknium1 closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/xiaomi Xiaomi MiLM type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants