fix(gateway): surface bootstrap failures to stderr (salvage #21157) - #21278
Merged
Conversation
Follow-up to the salvaged warning. Without the exception string, operators see "config validation failed" with no hint why.
23 tasks
Contributor
🔎 Lint report:
|
alt-glitch
added
type/bug
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three gateway bootstrap try/except blocks (IPv4 preference application, config-structure validation, deprecated-cwd warning) now surface failures to stderr instead of silently swallowing them. These run before
setup_logging()has initialized file logging (L14803) and before the module-levelloggeris defined (L543), soprint(..., file=sys.stderr)is the correct mechanism at this phase of boot.Changes
gateway/run.py: replaceexcept Exception: passwithprint(f" Warning: ...: {exc}", file=sys.stderr)in three pre-logger bootstrap blocks.Improvements during salvage
Original patch emitted a bare "Warning: X failed" with no exception text. Added the exception string so operators can actually diagnose what went wrong.
Validation
Compile check passes. Logic is unchanged — the three blocks still can't crash gateway boot if one of the validators fails.
Closes #21157 via salvage. Co-authored by @wabrent.