Skip to content

fix(terminal): handle ImportError for termios on Windows in password reader #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sertug17 wants to merge 1 commit into from
Closed

fix(terminal): handle ImportError for termios on Windows in password reader #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/terminal_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def read_password_thread():
break
chars.append(b)
result["password"] = b"".join(chars).decode("utf-8", errors="replace")
except (EOFError, KeyboardInterrupt, OSError):
except (EOFError, KeyboardInterrupt, OSError, ImportError, NotImplementedError):
result["password"] = ""
except Exception:
result["password"] = ""
Expand All @@ -218,12 +218,12 @@ def read_password_thread():
try:
import termios as _termios
_termios.tcsetattr(tty_fd, _termios.TCSAFLUSH, old_attrs)
except Exception:
except (Exception, ImportError, NotImplementedError):
pass
if tty_fd is not None:
try:
os.close(tty_fd)
except Exception:
except (Exception, ImportError, NotImplementedError):
pass
result["done"] = True

Expand Down