fix(terminal): handle ImportError for termios on Windows in password reader - #207
Closed
Sertug17 wants to merge 1 commit into
Closed
fix(terminal): handle ImportError for termios on Windows in password reader#207Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
guog
suggested changes
May 16, 2026
guog
left a comment
There was a problem hiding this comment.
代码审查:
🔴 Critical
- tools/terminal_tool.py:221 / tools/terminal_tool.py:226 — 异常捕获语法不规范。在 Python 中,
ImportError和NotImplementedError继承自Exception。当你写成except (Exception, ImportError, NotImplementedError)时,其实相当于只写了except Exception,这让特定的错误捕获失效。如果想遵循CONTRIBUTING.md中的规范,应将特定的错误和一般的Exception分开捕获:
except (ImportError, NotImplementedError):
pass
except Exception:
pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
import termiosraisesModuleNotFoundError(a subclass ofImportError). Theread_password_thread()function interminal_tool.pyonly caught(EOFError, KeyboardInterrupt, OSError), so Windows users would get an unhandled exception crash when sudo password reading was triggered.Same issue existed in the
finallyblock wheretermiosis imported again to restore terminal attributes.Root Cause
termiosis a Unix-only module. CONTRIBUTING.md explicitly calls out this pattern as a cross-platform requirement:Fix
ImportErrorandNotImplementedErrorImportErrorandNotImplementedErrorTesting
Verified the fix follows the exact pattern recommended in CONTRIBUTING.md.