fix(nix): refresh tui npm deps hash - #20058
Closed
stephenschoettler wants to merge 1 commit into
Closed
Conversation
Refresh the ui-tui fetchNpmDeps hash for the current package-lock.json and force fix-lockfiles to rebuild npmDeps while checking, so cached npm-deps outputs cannot mask lockfile drift.
Contributor
Author
|
CI update for maintainers:
This PR removes the Nix blocker from main. The remaining test failures should be handled as a separate base-CI unblocker so this focused Nix fix does not absorb unrelated test drift. |
Contributor
Author
|
Closing this as superseded by #20144, which already merged the same TUI npmDeps hash refresh and the cache-blind lockfile detection fix. I also rebased the local branch onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refreshes the
ui-tuiNix npm deps hash for the currentui-tui/package-lock.jsonon latest main.Latest affected main:
601e5f1d57cfd4ceefee50a6df05a860a1a602e825357077973, Ubuntu job74348475250hermes-tui> ERROR: npmDepsHash is out of dateThis also forces
fix-lockfilesto rebuild npmDeps while checking and while verifying a freshly applied hash. The latest failing run showed the package build detecting lockfile drift whilenix run .#fix-lockfiles -- --checkreportedok, because the checker could hit cached fixed-output derivations. Rebuilding makes the diagnostic match the real package build.Related: #19766 targets an older hash and does not include the checker cache fix.
Related Issue
Related to #19766.
Unblocks latest main Nix failure from run
25357077973.Type of Change
Changes Made
nix/tui.nix: update thefetchNpmDeps.hashforui-tuitosha256-MLcLhjTF6dgdvNBtJWzo8Nh19eNh/ZitD2b07nm61Tc=.nix/lib.nix: add--rebuildtofix-lockfilesnpmDeps builds so stale cached fixed-output derivations cannot hide lockfile drift.How to Test
nix build .#tui --no-link --print-build-logsand observe thehermes-tui> ERROR: npmDepsHash is out of datefailure.nix build .#tui --no-link --print-build-logsand observe the TUI Nix package build complete.nix run .#fix-lockfiles -- --checkand observe the hash check exit successfully.Validation Status
git diff --checknix build .#tui --no-link --print-build-logs, via nix-portable withNP_RUNTIME=bwrap, passed locally on Arch Linux x86_64.nix run .#fix-lockfiles -- --check, via nix-portable withNP_RUNTIME=bwrap, exited 0 locally. It rebuilttui.npmDeps; localweb.npmDepshit a transient invalid-output cache result and was skipped by the existing script handling.pytest tests/ -q, not run. This is a Nix-only lockfile/hash fix.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass. Not run for this Nix-only lockfile/hash fix.fix-lockfiles --checkvalidation.Documentation & Housekeeping
docs/, docstrings), or N/Acli-config.yaml.exampleif I added/changed config keys, or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows, or N/AScreenshots / Logs
Failure on latest main:
Focused local validation: