Skip to content

fix(nix): update npmDepsHash for hermes-tui - #19766

Closed
lazyeel wants to merge 1 commit into
NousResearch:mainfrom
lazyeel:main
Closed

fix(nix): update npmDepsHash for hermes-tui#19766
lazyeel wants to merge 1 commit into
NousResearch:mainfrom
lazyeel:main

Conversation

@lazyeel

@lazyeel lazyeel commented May 4, 2026

Copy link
Copy Markdown

What does this PR do?

This PR updates the npmDepsHash in nix/tui.nix to match the current package-lock.json inside the ui-tui directory.

The previous hash was causing a fixed-output derivation hash mismatch during the Nix flake build due to recent dependency updates (nanostores, etc.). I have verified that the web component still builds correctly and does not require a hash update.

Related Issue

Fixes #19760

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • Updated the hardcoded hash value in the npmDeps derivation inside nix/tui.nix to correctly match the updated package-lock.json in the ui-tui directory.

How to Test

  1. Checkout the main branch and attempt to build the TUI component using Nix: nix build .#tui. It will fail with an ERROR: npmDepsHash is out of date.
  2. Checkout this PR's branch.
  3. Run nix build .#tui again. Observe that the build now successfully completes.
  4. Run nix build .#web to verify that the web component still builds successfully and was not affected by this change.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages followConventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass (N/A for Nix builds)
  • I've added tests for my changes (N/A, the Nix flake evaluation and build itself acts as the test)
  • I've tested on my platform: NixOS unstable (x86_64-linux)

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

Error log on main before this fix:

> Validating consistency between /build/ui-tui/package-lock.json and /nix/store/...-npm-deps/package-lock.json
> 15d14
> <         "nanostores": "^1.2.0",
> 5306a5306
> >       "peer": true,
> 
> ERROR: npmDepsHash is out of date

@alt-glitch alt-glitch added type/bug Something isn't working P1 High — major feature broken, no workaround area/nix Nix flake, NixOS module, container packaging comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels May 4, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #19764 — same one-line npmDepsHash update in nix/tui.nix for #19760.

@alt-glitch alt-glitch added the duplicate This issue or pull request already exists label May 4, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #19764 — same one-line npmDepsHash update in nix/tui.nix for #19760.

@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #19764

@alt-glitch alt-glitch marked this as a duplicate of #19764 May 4, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Closing — the stale hash this fixed was already auto-corrected by the nix-lockfile-fix.yml workflow (#16285) in commit 13a7cbc (#20144). The auto-fix pipeline now handles npmDepsHash drift automatically on every push to main, so manual hash-bump PRs like this shouldn't be needed going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nix Nix flake, NixOS module, container packaging comp/tui Terminal UI (ui-tui/ + tui_gateway/) duplicate This issue or pull request already exists P1 High — major feature broken, no workaround type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Build failure in Nix flake: npmDepsHash is out of date for hermes-tui

2 participants