fix(nix): update npmDepsHash for hermes-tui - #19766
Closed
lazyeel wants to merge 1 commit into
Closed
Conversation
Collaborator
23 tasks
Collaborator
Collaborator
|
Duplicate of #19764 |
23 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
npmDepsHashinnix/tui.nixto match the currentpackage-lock.jsoninside theui-tuidirectory.The previous hash was causing a fixed-output derivation hash mismatch during the Nix flake build due to recent dependency updates (
nanostores, etc.). I have verified that thewebcomponent still builds correctly and does not require a hash update.Related Issue
Fixes #19760
Type of Change
Changes Made
hashvalue in thenpmDepsderivation insidenix/tui.nixto correctly match the updatedpackage-lock.jsonin theui-tuidirectory.How to Test
mainbranch and attempt to build the TUI component using Nix:nix build .#tui. It will fail with anERROR: npmDepsHash is out of date.nix build .#tuiagain. Observe that the build now successfully completes.nix build .#webto verify that the web component still builds successfully and was not affected by this change.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass (N/A for Nix builds)Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Error log on
mainbefore this fix: