Skip to content

fix: remove invalid prompt_toolkit ctrl-shift-c binding - #19918

Closed
emma17bot wants to merge 1 commit into
NousResearch:mainfrom
emma17bot:fix/prompt-toolkit-ctrl-shift-c-keybinding
Closed

fix: remove invalid prompt_toolkit ctrl-shift-c binding#19918
emma17bot wants to merge 1 commit into
NousResearch:mainfrom
emma17bot:fix/prompt-toolkit-ctrl-shift-c-keybinding

Conversation

@emma17bot

@emma17bot emma17bot commented May 4, 2026

Copy link
Copy Markdown

Summary

  • Remove the invalid c-S-c prompt_toolkit binding that prevents the CLI from starting
  • Let terminal emulators continue handling Ctrl+Shift+C copy natively
  • Add a regression test validating hard-coded CLI keybindings against prompt_toolkit

Test Plan

  • python -m pytest tests/hermes_cli/test_cli_keybindings.py -q
  • python -m py_compile cli.py tests/hermes_cli/test_cli_keybindings.py
  • timeout 5s hermes startup smoke test

@alt-glitch alt-glitch added type/bug Something isn't working P1 High — major feature broken, no workaround comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists labels May 4, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Superseded by #19919 (merged) — same fix (remove dead c-S-c binding). Also competes with open #19902 and #19906.

@alt-glitch

Copy link
Copy Markdown
Collaborator

Superseded by #19919 (merged)

@teknium1

teknium1 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Duplicate — the underlying bug was fixed on main before your PR landed.

Closing issue #19903 too. Thanks for jumping on it — appreciate the quick turnaround even if we only needed one of the fixes.

@teknium1 teknium1 closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P1 High — major feature broken, no workaround type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants