Skip to content

fix: remove invalid Ctrl+Shift+C keybinding - #19906

Closed
nomuvan wants to merge 1 commit into
NousResearch:mainfrom
nomuvan:fix/remove-invalid-ctrl-shift-c-binding-v2
Closed

fix: remove invalid Ctrl+Shift+C keybinding#19906
nomuvan wants to merge 1 commit into
NousResearch:mainfrom
nomuvan:fix/remove-invalid-ctrl-shift-c-binding-v2

Conversation

@nomuvan

@nomuvan nomuvan commented May 4, 2026

Copy link
Copy Markdown

Summary

  • Remove the @kb.add('c-S-c') prompt_toolkit binding that raises ValueError: Invalid key: c-S-c during CLI startup.
  • Leave Ctrl+Shift+C/Cmd+C handling to terminal emulators.
  • Add regression coverage that validates literal CLI keybinding declarations against prompt_toolkit.

Test Plan

  • python -m pytest tests/cli/test_cli_keybindings.py tests/cli/test_cli_extension_hooks.py -q
  • hermes --version
  • hermes chat -q 'pingとだけ返して' --quiet
  • Interactive hermes launch in tmux

@teknium1

teknium1 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Duplicate — the underlying bug was fixed on main before your PR landed.

Closing issue #19903 too. Thanks for jumping on it — appreciate the quick turnaround even if we only needed one of the fixes.

@teknium1 teknium1 closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P1 High — major feature broken, no workaround type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants