fix: close file descriptor in LocalEnvironment._update_cwd - #17300
Merged
Conversation
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
Contributor
Author
|
@teknium1 please check Sir |
Collaborator
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LocalEnvironment._update_cwd()uses a bareopen(self._cwd_file).read()call that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate over time in long sessions.Fix
Use a
withstatement so the fd is released promptly.Impact
Prevents file descriptor exhaustion in long-running sessions with many terminal commands.
Standalone resubmission of the fd-leak fix from #15552 (1 file, 2 lines changed).