fix: close file descriptor in LocalEnvironment._update_cwd - #15552
Closed
vominh1919 wants to merge 2 commits into
Closed
fix: close file descriptor in LocalEnvironment._update_cwd#15552vominh1919 wants to merge 2 commits into
vominh1919 wants to merge 2 commits into
Conversation
…m providers Fixes: - NousResearch#13766: CLI agents no longer emit MEDIA:/path tags (CLI has no attachment channel) - NousResearch#13765: Add 'from __future__ import annotations' to 64 files for Python 3.9 PEP-604 compatibility - NousResearch#13764: Model switch now searches custom_providers catalog before API probe Changes: - agent/prompt_builder.py: Extend CLI platform hint to prevent MEDIA: tag emission - cli.py: Load custom_providers unconditionally (not just for picker) - hermes_cli/model_switch.py: Add _find_model_in_custom_providers() helper, insert step c2 in PATH B - hermes_cli/models.py: normalize_provider() handles custom:* slugs - 64 files: Add 'from __future__ import annotations' for Python 3.9 compatibility
The bare open(self._cwd_file).read() call leaks a file descriptor on every terminal command execution. Use a with-statement so the fd is released promptly, preventing fd exhaustion in long sessions.
alt-glitch
added
type/bug
3 tasks
Contributor
|
Thanks for the contribution @vominh1919! The |
Contributor
Author
|
Resubmitted as a clean standalone 1-file PR: #17294 Only the fd-leak fix in |
teknium1
pushed a commit
that referenced
this pull request
Apr 29, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes #15552 (standalone resubmission)
donald131
pushed a commit
to donald131/hermes-agent
that referenced
this pull request
May 2, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
dannyJ848
pushed a commit
to dannyJ848/hermes-agent
that referenced
this pull request
May 17, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
Seven74AI
pushed a commit
to Seven74AI/hermes-agent
that referenced
this pull request
Jun 13, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
_update_cwd() uses a bare open(self._cwd_file).read() that never closes the file descriptor. This method runs on every terminal command execution, so the fd leaks accumulate in long sessions. Use a with statement so the fd is released promptly. Fixes NousResearch#15552 (standalone resubmission)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LocalEnvironment._update_cwd()uses a bareopen(self._cwd_file).read()call that never closes the file descriptor. This method runs on every terminal command execution, so the leak accumulates over time in long sessions.Fix
Use a
withstatement so the fd is released promptly.Impact
Prevents file descriptor exhaustion in long-running sessions with many terminal commands.