Skip to content

fix(gateway): add missing config.yaml mapping for telegram reply_to_mode - #17183

Closed
hash7in wants to merge 1 commit into
NousResearch:mainfrom
hash7in:fix/config-yaml-reply-to-mode
Closed

fix(gateway): add missing config.yaml mapping for telegram reply_to_mode#17183
hash7in wants to merge 1 commit into
NousResearch:mainfrom
hash7in:fix/config-yaml-reply-to-mode

Conversation

@hash7in

@hash7in hash7in commented Apr 29, 2026

Copy link
Copy Markdown

Problem

in config.yaml is silently ignored. Only env var works because never maps the yaml value to .

Other telegram-specific settings like already have this mapping — was just missed.

Fix

6 lines, same pattern as . Env var takes precedence when both are set.

telegram.reply_to_mode in config.yaml was silently ignored because
_build_gateway_config() never mapped it to PlatformConfig. Only the
TELEGRAM_REPLY_TO_MODE env var worked. This adds the missing mapping,
following the same pattern as disable_link_previews.
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery platform/telegram Telegram bot adapter area/config Config system, migrations, profiles labels Apr 29, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of closed #17176 (identical fix). Also overlaps with open #17117 which covers both Discord and Telegram reply_to_mode mapping.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused config fix. This is an automated hermes-sweeper review; the requested behavior is already implemented on current main.

  • Commit 6b76ea4707e75cba4d8a1fd6094c89d778fae412 (fix(gateway): load reply_to_mode from config.yaml for Discord and Telegram) implemented the Telegram YAML bridge and regression tests; it is included in release v2026.5.7.
  • Current plugins/platforms/telegram/adapter.py:8713-8719 reads telegram.reply_to_mode, supports the extra fallback, and preserves an existing TELEGRAM_REPLY_TO_MODE override.
  • Current regression coverage at tests/gateway/test_telegram_reply_mode.py:254-306 covers YAML values and environment precedence.
  • This also confirms the duplicate/sibling context noted by @alt-glitch.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/telegram Telegram bot adapter sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants