fix(gateway): map telegram reply_to_mode from config.yaml to PlatformConfig - #17176
Closed
hash7in wants to merge 1 commit into
Closed
fix(gateway): map telegram reply_to_mode from config.yaml to PlatformConfig#17176hash7in wants to merge 1 commit into
hash7in wants to merge 1 commit into
Conversation
…Config The reply_to_mode setting under telegram: in config.yaml was never mapped to PlatformConfig.reply_to_mode in _build_gateway_config(), so the value was always the default 'first' regardless of user config. This adds the missing mapping, consistent with how other telegram- specific settings (disable_link_previews, etc.) are handled.
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
reply_to_modesetting undertelegram:inconfig.yamlwas never mapped toPlatformConfig.reply_to_modein_build_gateway_config(). This means the value was always the default"first"regardless of what users configured.Setting
reply_to_mode: "off"in config.yaml had no effect — the gateway still threaded replies to the user's message.Fix
Adds the missing mapping in
load_gateway_config(), consistent with how other telegram-specific settings (disable_link_previews, etc.) are handled.Respects the existing env var override: if
TELEGRAM_REPLY_TO_MODEis set, the env var takes precedence (no change to existing behavior).Changes
gateway/config.py: 6 lines — maptelegram_cfg["reply_to_mode"]toplat_data["reply_to_mode"]