feat(agent): route background reviews via config - #15874
Closed
kdmarble wants to merge 1 commit into
Closed
Conversation
Collaborator
Collaborator
|
Likely duplicate of #15508 |
Author
|
Closing in favor of consolidating around one of the other implementations. All three PRs solve the same problem (configurable background review routing) and there's no value in keeping competing approaches open. Happy to fold any unique contributions from this PR into whichever implementation maintainers prefer, or help review #13647 / #15508 directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds optional
background_reviewconfiguration for routing background memory/skill review agents to a separateruntime.
By default, background reviews continue to inherit the active conversation model and provider. Users can now
configure a different provider, model, and max iteration count for those non-user-visible review turns.
Why
Background review agents can unintentionally compete with the active chat model/runtime. This allows users to
isolate that work onto a cheaper or separate endpoint without changing the visible chat session runtime.
How to test
Result:
312 passed
Also checked:
Platforms tested