fix: make /reasoning session-scoped by default - #15522
Closed
Alex-giao wants to merge 1 commit into
Closed
Conversation
- align /reasoning with /model semantics across CLI, gateway, and TUI - keep --global as the explicit persistence path - add coverage for malformed flag parsing and TUI session-create races
alt-glitch
added
type/bug
Collaborator
|
Likely duplicate of #14558 — same feature (make /reasoning session-scoped by default with --global flag). Please coordinate to avoid merge conflicts. |
This was referenced Apr 25, 2026
Contributor
|
Closing as superseded by #15533. Triage notes (high confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/reasoning <level>session-scoped by default across CLI, gateway, and TUI--globalpersistence semantics to match/model--globalparsing and TUI session-create racesTest Plan
scripts/run_tests.sh tests/cli/test_reasoning_command.py tests/gateway/test_reasoning_command.py tests/test_tui_gateway_server.pygit diff --checkNotes
originwas not permitted from this checkout, so the branch was pushed to the existing fork remote and the PR was opened fromAlex-giao:fix/reasoning-session-global.