Skip to content

feat: make /reasoning session-scoped by default - #14558

Closed
Alex-giao wants to merge 1 commit into
NousResearch:mainfrom
Alex-giao:feat/session-only-reasoning
Closed

feat: make /reasoning session-scoped by default#14558
Alex-giao wants to merge 1 commit into
NousResearch:mainfrom
Alex-giao:feat/session-only-reasoning

Conversation

@Alex-giao

Copy link
Copy Markdown

Summary

  • make /reasoning <level> session-scoped by default in CLI and gateway
  • add --global to persist reasoning changes to config.yaml
  • thread session-scoped reasoning overrides through gateway background/helper flows and reset cleanup
  • teach TUI config + slash status paths to respect the active session override
  • add regression coverage for CLI, gateway, background routing, reset cleanup, and TUI behavior

Test Plan

  • scripts/run_tests.sh tests/cli/test_reasoning_command.py tests/gateway/test_reasoning_command.py tests/gateway/test_session_model_reset.py tests/gateway/test_session_model_override_routing.py tests/test_tui_gateway_server.py
  • scripts/run_tests.sh tests/gateway/test_background_command.py tests/gateway/test_session_model_override_routing.py
  • git diff --check

Notes

  • I also attempted the full scripts/run_tests.sh suite in this environment, but it surfaced unrelated existing failures outside the touched areas before completion, so the verification above focuses on the directly impacted paths.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels Apr 23, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Closing as superseded by #15533.

Triage notes (high confidence):
Session-scoped /reasoning is already on main in gateway/run.py:2773 (_set_session_reasoning_override) and merged via PR #15533 (2026-04-26) 'fix(gateway): make /reasoning session-scoped by default'.

Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen.

(Bulk-closed during a CLI PR triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
@jussihuotari

Copy link
Copy Markdown

It seems to me that this was closed in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants