fix(web_server): guard GATEWAY_HEALTH_TIMEOUT against invalid env values - #14756
Merged
Conversation
float(os.getenv(...)) at module level raises ValueError on any non-numeric value, crashing the web server at import before it starts. Wrap in try/except with a warning log and fallback to 3.0s.
4 tasks
alt-glitch
added
type/bug
Collaborator
|
Likely duplicate of #14751 — same GATEWAY_HEALTH_TIMEOUT float() guard fix, cherry-picked onto current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #14751 (@sprmn24) onto current main.
Summary
_GATEWAY_HEALTH_TIMEOUT = float(os.getenv("GATEWAY_HEALTH_TIMEOUT", "3"))at module level in web_server.py crashes the entire web server at import if the env var holds a non-numeric value. Wrapped in try/except with a warning log and 3.0s fallback.Changes
hermes_cli/web_server.py: try/except around the bare float() parse; warns via existing_log.Validation
E2E with real imports against this worktree:
abc5.5Cherry-picked from PR #14751 commit 2beeedc, authorship preserved.