fix(web_server): guard GATEWAY_HEALTH_TIMEOUT against invalid env values - #14751
Closed
sprmn24 wants to merge 1 commit into
Closed
fix(web_server): guard GATEWAY_HEALTH_TIMEOUT against invalid env values#14751sprmn24 wants to merge 1 commit into
sprmn24 wants to merge 1 commit into
Conversation
float(os.getenv(...)) at module level raises ValueError on any non-numeric value, crashing the web server at import before it starts. Wrap in try/except with a warning log and fallback to 3.0s.
alt-glitch
added
type/bug
Collaborator
|
Related to #11375 — same pattern of unguarded float() on env var. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_GATEWAY_HEALTH_TIMEOUT = float(os.getenv("GATEWAY_HEALTH_TIMEOUT", "3"))runs at module level. Any non-numeric value (e.g.GATEWAY_HEALTH_TIMEOUT=abc) raisesValueErrorat import time, crashing the web server before it starts — with no useful error message.Type of Change
Root Cause
float()is called directly on the env var with no guard. A misconfigured environment silently kills the entire dashboard process at startup.Changes Made
float()call intry/except (ValueError, TypeError)_loglogger3.0seconds so the server starts normallyHow to Test
GATEWAY_HEALTH_TIMEOUT=abcin~/.hermes/.envhermes gatewaywith web dashboard enabledValueErrorChecklist
_loglogger already defined in the file