fix: adaptive color scheme for light terminal backgrounds (#12330) - #12337
Closed
vominh1919 wants to merge 1 commit into
Closed
fix: adaptive color scheme for light terminal backgrounds (#12330)#12337vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
…ixes NousResearch#12330) - Add terminal background detection via OSC 11 query, COLORFGBG env var, and HERMES_LIGHT_BACKGROUND override - Colors class dynamically resolves darker ANSI variants for light backgrounds - skin_engine auto-selects warm-lightmode skin when light background detected - Replace hardcoded ANSI codes in cli.py worktree functions with adaptive Colors
|
✓ Automated scan: no security concerns. Terminal color fix only. |
alt-glitch
added
type/bug
Collaborator
7 tasks
1 task
Contributor
|
Closing as superseded by #17113. Triage notes (medium confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12330
Text was hard to read on white/light terminal backgrounds. The existing light skins existed but were never auto-selected.
Changes:
hermes_cli/colors.py: Added 3-strategy terminal background detection (OSC 11 query, COLORFGBG env var, HERMES_LIGHT_BACKGROUND override). Colors class dynamically resolves darker ANSI variants for light backgrounds.hermes_cli/skin_engine.py: Auto-selects warm-lightmode skin when light background detected.cli.py: Replaced hardcoded ANSI codes in worktree functions with adaptive Colors.