fix(cli): auto-select daylight skin on light terminal backgrounds - #11536
Closed
dwc1997 wants to merge 1 commit into
Closed
fix(cli): auto-select daylight skin on light terminal backgrounds#11536dwc1997 wants to merge 1 commit into
dwc1997 wants to merge 1 commit into
Conversation
Collaborator
Auto-select the daylight skin when no display.skin is configured and the terminal appears to use a light background. Keep explicit skin selections unchanged and add regression tests for TERM_BACKGROUND-driven behavior.
dwc1997
force-pushed
the
fix/cli-light-terminal-default-skin
branch
from
May 1, 2026 03:36
d0b2fa6 to
3fa03ab
Compare
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves CLI readability on light terminal themes by auto-selecting a light-safe skin when no explicit skin is configured.
Previously, Hermes defaulted to the gold-heavy
defaultskin, which can be hard to read on white/light backgrounds. With this change, startup now uses a best-effort light terminal detection and falls back to the built-indaylightskin automatically.Explicit user settings are preserved: if
display.skinis set, Hermes continues using that exact skin with no auto override.Related Issue
Fixes #11300
Type of Change
Changes Made
hermes_cli/skin_engine.py:_looks_like_light_terminal()helperinit_skin_from_config()to:display.skindaylighton light terminals,defaultotherwisetests/hermes_cli/test_skin_engine.py:daylightdisplay.skinstill takes precedenceHow to Test
display.skinunset).TERM_BACKGROUND=light(orHERMES_LIGHT_TERMINAL=1)daylight.display.skin: defaultand verify auto-detection does not override it.Screenshots / Logs
N/A (startup behavior + test coverage)