Skip to content

test(sessions): scope the held-store gate's no-alternate-store check to gated actions #117829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
teknium1 wants to merge 1 commit into from
Closed

test(sessions): scope the held-store gate's no-alternate-store check to gated actions #117829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/hermes_cli/test_sessions_held_store_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,13 @@ def test_store_rewrites_refuse_and_name_the_holder_until_forced(action, state_db
assert f"PID {foreign_holder.pid} (" in out
assert f"Refusing `hermes sessions {action}`" in out and "--force" in out
# The gate scans the store the command actually opened, not some other resolver's file: no
# `hermes sessions` subcommand can point the command at another database, so the default
# resolver IS the operated-on path, and the refusal names it.
# GATED subcommand can point the command at another database, so the default resolver IS the
# operated-on path, and the refusal names it. (`set-journal-mode` does take `--db`, but it is
# not gated here — it runs its own holder scan against the path it was handed.)
assert str(state_db) in out
assert not [opt for sub in _sessions_subparsers().values() for a in sub._actions
assert not [opt
for name, sub in _sessions_subparsers().items() if name in sessions_cmd._HELD_STORE_ACTIONS
for a in sub._actions
for opt in a.option_strings if opt in ("--db", "--db-path", "--database")]

assert sessions_cmd.cmd_sessions(_args(action, force=True)) != 1
Expand Down
Loading