Repository navigation
Conversation
…to gated actions #117687 asserted that no `hermes sessions` subcommand exposes `--db`, which is what makes `_default_db_path()` provably the store the gated command opened. #117684 then added `hermes sessions set-journal-mode --db PATH`. Both are green alone and red together: main fails test_store_rewrites_refuse_and_name_the_holder_until_forced[optimize|optimize-storage|prune]. set-journal-mode is not gated by cmd_sessions — it runs its own holder scan against the path it is handed — so the invariant still holds for every action in _HELD_STORE_ACTIONS. Scope the assertion there instead of dropping it. Part of #110054
૮ >ﻌ< ა ci reviewran on 357b924 — test(sessions): scope the held-store gate's no-alternate-sto debug infoCI timingsCI timings · View report · View jobWall time 5m47s vs 6m20s (-8.7%). 5 job(s) slower, 7 faster,
|
Collaborator
Author
|
Superseded: main already carries the equivalent scoping (tests/hermes_cli/test_sessions_held_store_gate.py now restricts the no-alternate-store assertion to _HELD_STORE_ACTIONS). Closing as redundant. |
alt-glitch
added
type/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red: #117687 and #117684 are each green alone and conflict on landing.assert not [... "--db" ...]over EVERYhermes sessionssubparser — the proof that_default_db_path()is the store the gated command actually opened.hermes sessions set-journal-mode delete|walconverts an existing WAL store offline (#100896) #117684 then addedhermes sessions set-journal-mode --db PATH.Failing on main:
tests/hermes_cli/test_sessions_held_store_gate.py::test_store_rewrites_refuse_and_name_the_holder_until_forced[optimize|optimize-storage|prune](AssertionError: assert not ['--db']).set-journal-modeis not gated bycmd_sessions; it runs its own holder scan (foreign_state_db_holders) against the path it is handed, so the invariant is intact for the gated actions. This scopes the assertion to_HELD_STORE_ACTIONSrather than deleting it.Verified: red on current main (3 failed, 1 passed), green with this change;
test_sessions_held_store_gate.py,test_sessions_set_journal_mode.py,test_sessions_delete.pyall green together.Part of #110054