fix(update): out-of-tree venv installs refresh tool deps instead of pointing uv at <checkout>\venv (#116148, salvage #116293)

[teknium1]

hermes update on an install whose interpreter lives outside the checkout (%LOCALAPPDATA%\hermes\venvs\hermes, the layout the shipped Windows launchers pin) now hands uv the real venv, so hermes tools Python dependencies are refreshed instead of failing with Failed to inspect Python interpreter from active virtual environment.

• hermes_constants.py::project_venv_dir — the single choke point every updater call site routes through (project_venv_dir(root) or root / "venv" ×12) — falls back to the running interpreter's venv when the checkout has no venv//.venv/, for the checkout this module was loaded from only. In-tree venv still wins; a foreign root (test temp dir, another clone) still resolves to None.
• Covers both halves the issue lists in one place: the VIRTUAL_ENV exports (update_cmd.py::_pip_install_prefix, update_cmd_zip.py) and the stale probes (update_cmd_deps.py::_venv_dependency_set_stale, update_cmd_windows.py, main_install_repair.py, _install_repair.py) all see the real venv now.
• Tests: TestProjectVenvDirOutOfTree (2 invariants) in tests/test_hermes_constants.py.

Live repro (Linux, out-of-tree venv home-1/venvs/hermes, checkout with no in-tree venv, real _pip_install_prefix → uv pip install --dry-run):

	before (origin/main)	after
project_venv_dir(PROJECT_ROOT)	None	…/home-1/venvs/hermes
VIRTUAL_ENV handed to uv	<checkout>/venv, exists=False	…/venvs/hermes, exists=True
uv target	Using Python 3.11.15 environment at: <a different .venv found by directory walk> — deps land in the wrong environment (on the reporter's Windows box uv aborts instead: Failed to inspect Python interpreter)	Using Python 3.11.15 environment at: …/home-1/venvs/hermes
stale-probe venv_python_path(venv_dir).exists()	False → "not stale", probe no-ops	True

• New tests red with origin/main hermes_constants.py, green with the fix; tests/test_hermes_constants.py tests/hermes_cli/test_cmd_update.py tests/hermes_cli/test_lazy_refresh_venv_repair.py tests/hermes_cli/test_update_concurrent_quarantine.py tests/hermes_cli/test_update_sqlite_remediation.py → 166 passed (one test_cmd_update.py case failed twice under a loaded box while a sibling suite ran, then passed 3/3 alone on this head and 1/1 on base — load, not a regression).

Root cause: project_venv_dir() only looked inside the checkout, so every caller papered over the None with a fabricated <checkout>\venv that does not exist on out-of-tree installs.

Fixes #116148
Salvages #116293 (@Finn763) — cherry-picked; test file trimmed from 5 tests to 2 invariants folded into the existing tests/test_hermes_constants.py.
Supersedes #116300 (@rocks737, Co-authored-by) — same fix applied at the two VIRTUAL_ENV export sites via a new running_venv_root(); the choke-point fallback covers those sites and the stale probes the issue lists, so its extra resolver is not needed.

Dropped hunks

• fix(update): never point uv at a nonexistent venv on out-of-tree installs #116300 hermes_constants.py::running_venv_root, update_cmd.py::_resolved_install_venv_dir, update_cmd_zip.py hunk, tests/hermes_cli/test_update_out_of_tree_venv.py, test_lazy_refresh_venv_repair.py expectation change — subsumed by the project_venv_dir() fallback (re-probed: _pip_install_prefix yields the real venv, see table).
• fix(update): resolve the venv from the running interpreter on out-of-tree installs #116293 tests/test_project_venv_dir_out_of_tree.py — replaced by the 2 folded invariants (in-tree-wins, foreign-root-None, half-deleted-venv and base-interpreter cases were controls of unchanged behaviour).

Infographic

[github-actions]

૮ >ﻌ< ა ci review

_{ran on 056bc03 — fix(update): resolve the live venv from the running interpre}

debug info

CI timings

CI timings · View report · View job

Wall time 4m36s vs 8m50s (-47.9%). 6 job(s) slower, 6 faster,

• OS-specific tests / macOS-only tests: +27.0s
• OS-specific tests / Windows-only tests: -27.0s
• Detect affected areas: -19.0s
• Python lints / Windows footguns (blocking): +15.0s
• Check no committed infographics / check-no-committed-infographics: +5.0s