Repository navigation
Conversation
|
Independent verification on the PR head (c5eee06): slack suite 250/250 green (1 skipped) on Linux. No findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Slack working-status regression reported in #110374 across both Slack API modes.
processingwhile working andactivewhen clearing throughagents.sessions.setStatus.assistant.threads.setStatusonly when Slack rejects the Agent Sessions endpoint.agents.sessions.renameunchanged for thread titles.Why this differs from the existing alternatives
Existing PRs for #110374 generally choose either enum-only Agent Sessions status or legacy-only free-text status. This PR combines the compatible parts:
Root cause
Hermes selected
agents.sessions.setStatuswhen slack-sdk 3.44+ exposed the typed method, but continued sending legacy free-text phrases and an empty string. The new endpoint accepts onlyactive | processing | suspended | closed; Slack returnedinvalid_arguments, which the adapter logged only at DEBUG.Validation
scripts/run_tests.sh tests/gateway/test_slack.py -q— 251 passed.uv lock --check— passed.git diff --check— passed.Live Slack API verification
Against the affected real workspace/thread:
agents.sessions.setStatus(status="processing")→ successagents.sessions.setStatus(status="active")→ successassistant.threads.setStatus(status="is testing the working indicator...")→ successassistant.threads.setStatus(status="")→ successRelated work
This is a hybrid compatibility alternative to #109914, #110389, #110391, #111820, and #113698. It incorporates the enum contract while retaining a bounded, per-workspace legacy fallback for rejected Agent Sessions installations.