Repository navigation
Conversation
Competing with #110391 for the same fix (#110374). #110391 pins the legacy |
KoNit-K
force-pushed
the
fix/slack-status-sdk-3-44-110374
branch
from
September 17, 2026 13:56
0e71cc5 to
529dcb3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores the Slack working-status indicator when slack-sdk 3.44 or newer routes status calls through the Agent Sessions API. Agent Sessions now receives its supported lifecycle values while the legacy Slack API keeps its existing text behavior.
Related Issue
Fixes #110374
Type of Change
Changes Made
plugins/platforms/slack/adapter.py— map Agent Sessions status requests to supported lifecycle values while retaining the legacy API contract.tests/gateway/test_slack.py— cover lifecycle status mapping for typing, clears, and the existing Agent Sessions route.How to Test
HERMES_PYTHON=/Users/blockkonit./Dev/hermes/hermes-agent/.venv/bin/python scripts/run_tests.sh tests/gateway/test_slack.py— 244 passed.HERMES_PYTHON=/Users/blockkonit./Dev/hermes/hermes-agent/.venv/bin/python scripts/run_tests.sh tests/gateway/test_slack.py::TestAgentSessionsApiRouting— 6 passed.processingandactive.scripts/run_tests.sh tests/gateway/test_slack.pyscripts/run_tests.sh tests/gateway/test_slack.py::TestAgentSessionsApiRoutingEvidence
HERMES_PYTHON=/Users/blockkonit./Dev/hermes/hermes-agent/.venv/bin/python scripts/run_tests.sh tests/gateway/test_slack.py— 244 passed. — 244 passedChecklist
Code
Documentation & Housekeeping
cli-config.yaml.example: N/ACONTRIBUTING.mdorAGENTS.md: N/A