fix(tools): skip credential pool inheritance when override_base_url differs - #11456
Closed
nsyring wants to merge 0 commit into
Closed
fix(tools): skip credential pool inheritance when override_base_url differs#11456nsyring wants to merge 0 commit into
nsyring wants to merge 0 commit into
Conversation
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
4 times, most recently
from
April 21, 2026 09:27
6e0d1e5 to
9064531
Compare
10 tasks
Collaborator
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
from
April 25, 2026 05:55
9064531 to
3e5dd43
Compare
13 tasks
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
11 times, most recently
from
May 5, 2026 13:52
45f4880 to
7898788
Compare
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
8 times, most recently
from
May 12, 2026 09:04
5f2b878 to
1f7b129
Compare
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
10 times, most recently
from
May 26, 2026 06:18
63c27b9 to
6136d06
Compare
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
11 times, most recently
from
June 2, 2026 06:20
1facadd to
11650ba
Compare
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
7 times, most recently
from
June 6, 2026 21:20
5e9c19e to
f8f5349
Compare
nsyring
force-pushed
the
fix/delegation-pool-fix
branch
from
June 11, 2026 06:45
f8f5349 to
4829f8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where subagents using a different API endpoint (
override_base_url) incorrectly inherited the parent agent's credential pool, causing 401 authentication failures.When delegating to a provider with a different base URL (e.g., parent uses OpenRouter, subagent uses Mistral), the subagent should use its own credentials, not the parent's pool.
Related Issue
No existing issue.
Type of Change
Changes Made
tools/delegate_tool.py: Add URL comparison guard in_build_child_agent— skip pool inheritance whenoverride_base_urldiffers from parent's base URL. Trailing-slash normalization prevents false mismatches.tests/tools/test_delegation_pool.py: 4 tests covering same-URL inheritance, different-URL skip, trailing-slash normalization, and empty override.How to Test
pytest tests/tools/test_delegation_pool.py -v— all 4 tests passChecklist
pytest tests/ -qpasses