fix: home channel auto-prompt now checks yaml config - #10722
Closed
nightq wants to merge 1 commit into
Closed
Conversation
…nv var Fixes NousResearch#10581 Root cause: The one-time home channel prompt only checked the env var (os.getenv(f"{PLATFORM}_HOME_CHANNEL")) but never consulted the yaml-persisted config that /sethome writes. This caused the prompt to re-fire for fresh sessions even after a user had already run /sethome. Fix: Check both env var and config.get_home_channel() before showing the prompt. The prompt now only appears if neither source has a home channel set. Changes: - Modified home channel check in gateway/run.py to check both env var and yaml config before showing the one-time prompt
Collaborator
Contributor
|
Thanks for tracing the home-channel prompt path. This is now redundant because current
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the home channel auto-prompt to check yaml config in addition to env var.
Root Cause
The one-time home channel prompt only checked the env var (
os.getenv(f"{PLATFORM}_HOME_CHANNEL")) but never consulted the yaml-persisted config that/sethomewrites. This caused the prompt to re-fire for fresh sessions even after a user had already run/sethome.Fix
Check both env var and
config.get_home_channel()before showing the prompt. The prompt now only appears if neither source has a home channel set.Changes
gateway/run.pyto check both env var and yaml config before showing the one-time promptTest Plan
Closes #10581