fix: check config.yaml for home channel setting - #10632
Closed
nightq wants to merge 1 commit into
Closed
Conversation
Fixes NousResearch#10581 Root cause: The home channel auto-prompt only checked the environment variable, not the yaml config that /sethome writes to. This caused the prompt to re-fire even after /sethome was run. Fix: Check both os.getenv() and config.yaml when determining if home channel is set. Falls back to config.yaml if env var is not set.
2 tasks
Collaborator
Collaborator
Contributor
|
Thanks for the focused report and patch. The underlying
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix home channel auto-prompt to check both env var and config.yaml.
Root Cause
The home channel auto-prompt only checked the environment variable, not the yaml config that /sethome writes to. This caused the prompt to re-fire even after /sethome was run.
Fix
Check both os.getenv() and config.yaml when determining if home channel is set. Falls back to config.yaml if env var is not set.
Closes #10581