Skip to content

fix: check config.yaml for home channel setting - #10632

Closed
nightq wants to merge 1 commit into
NousResearch:mainfrom
nightq:fix/issue-10581-home-channel-config
Closed

fix: check config.yaml for home channel setting#10632
nightq wants to merge 1 commit into
NousResearch:mainfrom
nightq:fix/issue-10581-home-channel-config

Conversation

@nightq

@nightq nightq commented Apr 16, 2026

Copy link
Copy Markdown

Summary

Fix home channel auto-prompt to check both env var and config.yaml.

Root Cause

The home channel auto-prompt only checked the environment variable, not the yaml config that /sethome writes to. This caused the prompt to re-fire even after /sethome was run.

Fix

Check both os.getenv() and config.yaml when determining if home channel is set. Falls back to config.yaml if env var is not set.

Closes #10581

Fixes NousResearch#10581

Root cause: The home channel auto-prompt only checked the environment
variable, not the yaml config that /sethome writes to. This caused the
prompt to re-fire even after /sethome was run.

Fix: Check both os.getenv() and config.yaml when determining if home
channel is set. Falls back to config.yaml if env var is not set.
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery area/config Config system, migrations, profiles labels Apr 25, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competes with #10722 and #12391 for the same fix on #10581 — home channel auto-prompt should check config.yaml not just env var.

@alt-glitch

Copy link
Copy Markdown
Collaborator

Competes with #10722 and #12391 for the same fix on #10581.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused report and patch. The underlying /sethome persistence behavior is already implemented on current main through a different, now-authoritative storage path. This is an automated hermes-sweeper review.

  • Commit 1d5e25f35367af7ff15856bca232ba44bd0bc84f changed /sethome to persist home-channel targets in .env rather than top-level config.yaml keys.
  • Current gateway/slash_commands.py:2430-2452 saves the value through save_env_value() and keeps the running gateway configuration synchronized.
  • hermes_cli/config.py:7602 updates os.environ immediately, gateway/run.py:1306-1311 reloads .env at gateway startup, and gateway/run.py:11401-11402 suppresses the prompt when the home target exists.
  • The PR discussion notes competing fixes (fix: home channel auto-prompt now checks yaml config #10722 and fix: allow home channel from config.yaml to be recognized #12391); this PR predates the current persistence implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Home-channel auto-prompt only checks env var, never falls back to yaml config

3 participants