Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructors, interfaces, this scope, getters and virtual modifiers #1102

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

ggiraldez
Copy link
Collaborator

@ggiraldez ggiraldez commented Sep 23, 2024

This PR adds support for several new areas:

  • Contract constructors are now properly connected to the contract lexical scope
  • Calling a contract constructor using named parameters
  • this provides a scope with access to the current contracts functions
  • State variables declared public are exposed as external functions
  • Improve function modifiers by allowing and correctly resolving inherited and virtual ones
  • Support interface inheritance

Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 5361a4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggiraldez ggiraldez mentioned this pull request Sep 23, 2024
34 tasks
@ggiraldez ggiraldez changed the title Improve support for Solidity bindings: constructors, this scope, getters and virtual modifiers Constructors, this scope, getters and virtual modifiers Sep 23, 2024
@ggiraldez ggiraldez changed the title Constructors, this scope, getters and virtual modifiers Constructors, interfaces, this scope, getters and virtual modifiers Sep 24, 2024
@ggiraldez ggiraldez marked this pull request as ready for review September 25, 2024 06:48
@ggiraldez ggiraldez requested a review from a team as a code owner September 25, 2024 06:48
@OmarTawfik OmarTawfik added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 2, 2024
auto-merge was automatically disabled October 3, 2024 04:50

Head branch was pushed to by a user without write access

@OmarTawfik OmarTawfik added this pull request to the merge queue Oct 3, 2024
Merged via the queue into NomicFoundation:main with commit 9126cda Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants