-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance tests for bindings API #1100
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of questions. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I implemented the remaining suggestions in the comments and sent a PR against your branch. If you like the changes, we can merge it first before merging this PR.
Thank you, those look great! I already merged your PR. |
This PR adds performance tests to exercise the bindings API:
create_bindings
creates a blank Bindings object, useful as a baseline and to later measure the cost of adding the built-insbindings
which construct the stack graphs and other related bindings structures for the performance testing dataset filesresolve_references
attempts to resolve all the references found in the dataset files