Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifiers, named arguments calls, resolution of call outputs #1090

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Modifiers, named arguments calls, resolution of call outputs #1090

merged 8 commits into from
Sep 4, 2024

Conversation

ggiraldez
Copy link
Collaborator

@ggiraldez ggiraldez commented Aug 29, 2024 •
edited
Loading

Adds binding rules in Solidity for:

  • function modifiers (pending virtual/override lookups)
  • type resolution in custom errors and events
  • function calls with named parameters
  • emit/revert with named parameters
  • call options (for external calls)
  • fallback and receive functions
  • new expressions
  • type resolution for function calls and new expressions

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: aae869f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggiraldez ggiraldez mentioned this pull request Aug 29, 2024
Open
34 tasks
@ggiraldez ggiraldez changed the title Binding rules for function modifiers, type resolution in events/errors and calls with named arguments Function modifiers, binding resolution in events/errors and named arguments calls Aug 30, 2024
@ggiraldez ggiraldez changed the title Function modifiers, binding resolution in events/errors and named arguments calls Function modifiers, named arguments calls and resolution of call outputs Aug 31, 2024
@ggiraldez ggiraldez changed the title Function modifiers, named arguments calls and resolution of call outputs Modifiers, named arguments calls, resolution of call outputs Aug 31, 2024
@ggiraldez ggiraldez marked this pull request as ready for review August 31, 2024 00:17
@ggiraldez ggiraldez requested a review from a team as a code owner August 31, 2024 00:17
OmarTawfik
OmarTawfik approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few tiny suggestions. But otherwise, LGTM!

OmarTawfik
OmarTawfik approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@OmarTawfik OmarTawfik added this pull request to the merge queue Sep 4, 2024
Merged via the queue into NomicFoundation:main with commit dd20a02 Sep 4, 2024
1 check passed
@ggiraldez ggiraldez deleted the function-modifiers branch September 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggiraldez @OmarTawfik