Skip to content

Remove shouldBeReported from error descriptors that don't need it#8148

Merged
alcuadrado merged 2 commits intomainfrom
dont-report-non-bugs
Apr 15, 2026
Merged

Remove shouldBeReported from error descriptors that don't need it#8148
alcuadrado merged 2 commits intomainfrom
dont-report-non-bugs

Conversation

@alcuadrado
Copy link
Copy Markdown
Member

No description provided.

@alcuadrado alcuadrado added the no docs needed This PR doesn't require links to documentation label Apr 15, 2026
Copilot AI review requested due to automatic review settings April 15, 2026 13:29
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 49ec5d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
hardhat Patch
@nomicfoundation/hardhat-ignition Patch
@nomicfoundation/hardhat-verify Patch
@nomicfoundation/hardhat-errors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Hardhat’s error descriptors to avoid sending telemetry reports for errors that are considered expected/non-bug conditions.

Changes:

  • Removed shouldBeReported: true from a small set of error descriptors (Core, Ignition, Verify) so they won’t be sent to Sentry.
  • Added a changeset to publish patch releases for the affected packages.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/hardhat-errors/src/descriptors.ts Removes shouldBeReported from selected error descriptors so they won’t be telemetry-reported.
.changeset/dont-report-expected-errors.md Declares patch bumps for Hardhat and related packages to ship the reporting behavior change.

@alcuadrado alcuadrado added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@alcuadrado alcuadrado added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@alcuadrado alcuadrado added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 4f16e06 Apr 15, 2026
270 checks passed
@alcuadrado alcuadrado deleted the dont-report-non-bugs branch April 15, 2026 21:21
@github-actions github-actions Bot mentioned this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no docs needed This PR doesn't require links to documentation no peer bump needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants