Add splitTestsCompilation solidity setting (11): closing PR#8138
Merged
alcuadrado merged 15 commits intodont-split-compilationsfrom Apr 16, 2026
Merged
Add splitTestsCompilation solidity setting (11): closing PR#8138alcuadrado merged 15 commits intodont-split-compilationsfrom
splitTestsCompilation solidity setting (11): closing PR#8138alcuadrado merged 15 commits intodont-split-compilationsfrom
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Completes the splitTestsCompilation effort by removing the internal spec document and adding a plugin-facing migration guide describing the shipped behavior and integration impact.
Changes:
- Removed
SPLIT_TESTS_COMPILATION_SPEC.md(previous internal spec). - Added
PLUGIN_MIGRATION_GUIDE.mddocumenting plugin migration considerations. - Added a temporary internal placeholder file intended to trigger full CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
SPLIT_TESTS_COMPILATION_SPEC.md |
Removes the internal spec document from the repo. |
PLUGIN_MIGRATION_GUIDE.md |
Adds migration guidance for plugin authors regarding unified vs split compilation behavior. |
packages/hardhat/src/internal/to-be-deleted.ts |
Introduces a CI-trigger placeholder file (should not be merged as-is). |
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
cc2c74c to
9be26a9
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
99ca483 to
01b6cc4
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
9be26a9 to
99fb930
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
01b6cc4 to
1f89c15
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
99fb930 to
c968c91
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
1f89c15 to
b0bbef7
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
c968c91 to
cd08cc6
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
b0bbef7 to
633a7fb
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
cd08cc6 to
7a1cec5
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
633a7fb to
badace1
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
7a1cec5 to
a042299
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
badace1 to
f8138c5
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
a042299 to
db11bbe
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
f8138c5 to
2b8bbc1
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
db11bbe to
bc64d7a
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
2b8bbc1 to
8c2c275
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
bc64d7a to
bea3c22
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
8c2c275 to
cee9ebc
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
bea3c22 to
70b4ec1
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
2 times, most recently
from
0602ff6 to
64cbf4c
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-10
branch
from
c3ec0c9 to
24ef213
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-11
branch
from
64cbf4c to
3d2cb10
Compare
schaable
approved these changes
Apr 16, 2026
Base automatically changed from
dont-split-compilations-phase-10
to
dont-split-compilations
April 16, 2026 16:38
Co-authored-by: Luis Schaab <schaable@gmail.com>
Co-authored-by: Luis Schaab <schaable@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the last few changes to complete the effort, and do some cleanup work without having to rebase everything.
The PLUGIN_MIGRATION_GUIDE.md is committed so it can be reviewed, but will be delated.
The file
packages/hardhat/src/internal/to-be-deleted.tswas added so that this PR triggers the full CI, but it should be deleted.This PR is expected to pass all the checks.