Add splitTestsCompilation solidity setting (6): Solidity test runner updates#8133
Merged
alcuadrado merged 15 commits intodont-split-compilationsfrom Apr 16, 2026
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Hardhat’s Solidity test runner (hardhat test solidity) to behave correctly in both unified and split compilation modes, aligning test compilation/execution with the new splitTestsCompilation setting and introducing clearer error reporting for invalid/uncached selections.
Changes:
- Add mode-independent validation that selected
testFilesare actually Solidity tests, and introduce dedicated errors for “not tests” and “not compiled with --no-compile”. - Update unified mode to compile selectively via a single
build({ files: testFiles })and derive runnable test roots from the build result. - Adjust the Solidity test runner streaming implementation to use a native Node.js
Readable, and expand internal test coverage/fixtures.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SPLIT_TESTS_COMPILATION_SPEC.md | Updates the spec for Solidity test runner semantics across split/unified modes |
| packages/hardhat/test/internal/builtin-plugins/solidity-test/task-action.ts | Extends tests to cover new validation/errors and unified-mode behavior |
| packages/hardhat/test/fixture-projects/solidity-test/test/contracts/deprecated/NormalTest.t.sol | Adds fixture test for non-deprecated behavior |
| packages/hardhat/test/fixture-projects/solidity-test/test/contracts/deprecated/DeprecatedTestFail.t.sol | Adds fixture test that triggers deprecated testFail* warning |
| packages/hardhat/src/internal/builtin-plugins/solidity/tasks/build.ts | Minor refactor to simplify root path normalization |
| packages/hardhat/src/internal/builtin-plugins/solidity-test/task-action.ts | Implements new unified-mode build behavior, early validation, and --no-compile checks |
| packages/hardhat/src/internal/builtin-plugins/solidity-test/runner.ts | Switches test event streaming to a native Node.js Readable |
| packages/hardhat-errors/src/descriptors.ts | Adds new Solidity test runner error descriptors (814, 815) |
| cspell.config.mts | Ignores fixture-project build outputs (artifacts/cache) for spellchecking |
alcuadrado
force-pushed
the
dont-split-compilations-phase-5
branch
from
ec3246e to
4b0535f
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-6
branch
2 times, most recently
from
50c9d99 to
d787c3d
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-5
branch
2 times, most recently
from
39c9605 to
a778847
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-6
branch
from
d787c3d to
5a1a3d2
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-5
branch
from
a778847 to
cfb761c
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-6
branch
from
5a1a3d2 to
7fb9a86
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-5
branch
from
cfb761c to
908198d
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-6
branch
from
7fb9a86 to
bf63fb6
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-5
branch
from
908198d to
3e8e721
Compare
alcuadrado
force-pushed
the
dont-split-compilations-phase-6
branch
from
bf63fb6 to
0460272
Compare
schaable
approved these changes
Apr 15, 2026
| * a draft that may change in the future. | ||
| * | ||
| * TODO: Once the signature is finalized, give feedback to the EDR team. | ||
| * Important TODO: Transform this into an AsyncGenerator<SuiteResult, SolidityTestResult, void> |
Member
There was a problem hiding this comment.
we should create an issue to track this, otherwise it's likely to get forgotten. It would be good to clean this up while it's still fresh in our minds
|
|
||
| async function loadArtifacts( | ||
| solidity: SolidityBuildSystem, | ||
| scopes: Array<"contracts" | "tests">, |
|
|
||
| const verbosity = hre.globalOptions.verbosity; | ||
| const resolvedTestFilesArgument = testFiles.map((f) => | ||
| resolveFromRoot(process.cwd(), f), |
Member
There was a problem hiding this comment.
should we use hre.config.paths.root instead of process.cwd() here?
Member
Author
There was a problem hiding this comment.
This has to be aligned with build. I'll add a comment about it.
Base automatically changed from
dont-split-compilations-phase-5
to
dont-split-compilations
April 16, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
test soliditytask so that it works with and withoutsplitTestsCompilation. Just like thebuildone, this is one of the most complex PRs, product-wise.Some failures in external plugins are expected, mainly from typechain