Use code 3 for JSON-RPC responses where there has been a revert by ChristopherDedominici · Pull Request #8104 · NomicFoundation/hardhat

ChristopherDedominici · 2026-04-02T12:36:09Z

changeset-bot · 2026-04-02T12:36:16Z

🦋 Changeset detected

Latest commit: 92ba0a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@nomicfoundation/hardhat-ethers	Patch
@nomicfoundation/hardhat-ignition-viem	Patch
@nomicfoundation/hardhat-ignition	Patch
@nomicfoundation/hardhat-toolbox-viem	Patch
@nomicfoundation/hardhat-viem-assertions	Patch
@nomicfoundation/hardhat-viem	Patch
hardhat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

Updates Hardhat’s JSON-RPC error handling to align revert responses with the de facto geth/anvil convention (error code: 3 and raw hex revert data), improving compatibility with tooling that expects this shape (per #8043).

Changes:

Treat errors with numeric code === 3 as revert errors and emit geth/anvil-style JSON-RPC error responses (raw hex data).
Add code = 3 (and name) to SolidityError so stack-trace-based reverts propagate with the expected JSON-RPC error code.
Update node JSON-RPC handler tests to validate the new response shape for code-3 errors.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
packages/hardhat/test/internal/builtin-plugins/node/json-rpc/handler.ts	Adjusts tests to assert geth/anvil-style revert error formatting for code-3 errors.
packages/hardhat/src/internal/builtin-plugins/node/json-rpc/handler.ts	Updates `_handleError` to avoid wrapping code-3 errors and to serialize revert `data` as a raw hex string.
packages/hardhat/src/internal/builtin-plugins/network-manager/edr/stack-traces/stack-trace-solidity-errors.ts	Adds `SolidityError.CODE`/`code` (3) and sets `name` to ensure revert errors carry the expected code.

…code-3

…o error-code-3

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

github-actions · 2026-04-08T14:38:00Z

hardhat

Total size of the bundle: 246M
Total number of dependencies (including transitive): 48

List of dependencies (sorted by size)

238M	total
37M	@nomicfoundation/edr-linux-x64-musl
37M	@nomicfoundation/edr-linux-x64-gnu
34M	@nomicfoundation/edr-linux-arm64-musl
34M	@nomicfoundation/edr-linux-arm64-gnu
25M	@nomicfoundation/edr-darwin-x64
24M	@nomicfoundation/edr-win32-x64-msvc
21M	@nomicfoundation/edr-darwin-arm64
7.3M	@sentry/core
5.2M	zod
2.7M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@noble/hashes
1.1M	@nomicfoundation/hardhat-utils
884K	@nomicfoundation/hardhat-vendored
864K	@streamparser/json
624K	micro-packed
592K	tsx
588K	@nomicfoundation/hardhat-errors
492K	@scure/bip39
476K	@nomicfoundation/edr
408K	json-stream-stringify
368K	ethereum-cryptography
344K	fast-equals
332K	@streamparser/json-node
320K	enquirer
320K	@nomicfoundation/hardhat-zod-utils
288K	semver
200K	ws
180K	chokidar
176K	get-tsconfig
168K	esbuild
168K	@scure/base
136K	adm-zip
96K	@scure/bip32
92K	chalk
72K	@nomicfoundation/solidity-analyzer
68K	debug
60K	readdirp
56K	rfdc
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
36K	p-map
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	ms

socket-security · 2026-04-08T14:38:41Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	viem@2.43.5 ⏵ 2.47.6	⁺¹		⁺¹

View full report

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 7 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

…only once

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

alcuadrado · 2026-04-10T17:42:10Z

 import { assertHardhatInvariant } from "@nomicfoundation/hardhat-errors";
 import { ensureError } from "@nomicfoundation/hardhat-utils/error";
-import { isPrefixedHexString } from "@nomicfoundation/hardhat-utils/hex";
+import {


I don't get why this needs to be changed. I would have assumed that it was still working as expected.

If I revert the changes to this package, except for the package.json, the tests still pass.

Done here: b5e2f69

alcuadrado · 2026-04-10T17:43:19Z

@@ -0,0 +1,176 @@
+import type { HardhatViemHelpers } from "@nomicfoundation/hardhat-viem/types";


I think this tests should be present in hardhat-viem, not this package.

Done here: 5cb67ab

…code-3

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

alcuadrado

left a tiny comment but LGTM

Co-authored-by: Patricio Palladino <email@patriciopalladino.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot · 2026-04-14T09:42:11Z

+      server = await hre.network.createServer();
+      ({ address, port } = await server.listen());
+    });
+
+    after(async () => {
+      await server.close();
+    });
+
+    beforeEach(async () => {
+      ({ viem } = await hre.network.connect({
+        network: "localhost",
+        override: {
+          url: `http://${address}:${port}`,
+        },


In the HTTP suite, the test uses the address returned by server.listen() to build the client URL. When the JSON-RPC server is bound to 0.0.0.0/:: (common in Docker/CI), that address is not always a reliable connect target for HTTP clients and can make this test flaky. Prefer binding the server explicitly to 127.0.0.1 (e.g. via hre.network.createServer("default", "127.0.0.1")) and using 127.0.0.1 in the override URL, while still keeping port from listen().

draft solution

4a1208f

Copilot AI review requested due to automatic review settings April 2, 2026 12:36

ChristopherDedominici marked this pull request as draft April 2, 2026 12:36

github-actions Bot added the status:triaging label Apr 2, 2026

github-actions Bot assigned kanej Apr 2, 2026

ChristopherDedominici removed the status:triaging label Apr 2, 2026

ChristopherDedominici assigned ChristopherDedominici and unassigned kanej Apr 2, 2026

Copilot started reviewing on behalf of ChristopherDedominici April 2, 2026 12:36 View session

ChristopherDedominici added this to Hardhat Apr 2, 2026

github-project-automation Bot moved this to Backlog in Hardhat Apr 2, 2026

ChristopherDedominici moved this from Backlog to In Progress in Hardhat Apr 2, 2026

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Comment thread packages/hardhat/src/internal/builtin-plugins/node/json-rpc/handler.ts

ChristopherDedominici added 4 commits April 7, 2026 09:44

use error code 3 from SolidityError

58c6d15

align viem-assetions packages

693af7b

Merge branch 'main' of github.com:NomicFoundation/hardhat into error-…

38469a8

…code-3

Create cool-radios-type.md

e27a7ad

Copilot AI review requested due to automatic review settings April 7, 2026 10:15

Merge branch 'error-code-3' of github.com:NomicFoundation/hardhat int…

fdbe457

…o error-code-3

Copilot started reviewing on behalf of ChristopherDedominici April 7, 2026 10:15 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

ChristopherDedominici commented Apr 7, 2026

View reviewed changes

Comment thread packages/hardhat/src/internal/builtin-plugins/node/json-rpc/handler.ts Outdated

ChristopherDedominici added 2 commits April 7, 2026 13:30

clean code and add tests

6f69bf0

lint fix

e8a096b

Copilot AI review requested due to automatic review settings April 8, 2026 14:36

Copilot started reviewing on behalf of alcuadrado April 8, 2026 14:36 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread packages/hardhat-viem-assertions/test/internal/assertions/revert/revert-error-chain.ts Outdated

Comment thread packages/hardhat-viem/test/revert-error-chain.ts

Comment thread packages/hardhat-viem/test/revert-error-chain.ts

add check on raw filed for viem + use useEphemeralFixtureProject …

b854121

…only once

ChristopherDedominici marked this pull request as ready for review April 10, 2026 12:42

Copilot AI review requested due to automatic review settings April 10, 2026 12:42

Copilot started reviewing on behalf of ChristopherDedominici April 10, 2026 12:43 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

alcuadrado reviewed Apr 10, 2026

View reviewed changes

alcuadrado requested changes Apr 10, 2026

View reviewed changes

github-project-automation Bot moved this from In Progress to In Review in Hardhat Apr 10, 2026

ChristopherDedominici added 2 commits April 13, 2026 12:28

revert src code and test

b5e2f69

move test in viem package

5cb67ab

Copilot AI review requested due to automatic review settings April 13, 2026 12:46

Copilot started reviewing on behalf of ChristopherDedominici April 13, 2026 12:46 View session

Merge branch 'main' of github.com:NomicFoundation/hardhat into error-…

752401d

…code-3

Copilot AI reviewed Apr 13, 2026

View reviewed changes

ChristopherDedominici added the no peer bump needed label Apr 13, 2026

ChristopherDedominici requested a review from alcuadrado April 13, 2026 12:52

alcuadrado reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/hardhat-viem/test/revert-error-chain.ts Outdated

alcuadrado approved these changes Apr 13, 2026

View reviewed changes

Update packages/hardhat-viem/test/revert-error-chain.ts

92ba0a7

Co-authored-by: Patricio Palladino <email@patriciopalladino.com>

Copilot AI review requested due to automatic review settings April 14, 2026 09:36

Copilot started reviewing on behalf of ChristopherDedominici April 14, 2026 09:37 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

ChristopherDedominici added this pull request to the merge queue Apr 14, 2026

Merged via the queue into main with commit 1039dbc Apr 14, 2026
300 checks passed

ChristopherDedominici deleted the error-code-3 branch April 14, 2026 10:08

github-project-automation Bot moved this from In Review to Done in Hardhat Apr 14, 2026

github-actions Bot mentioned this pull request Apr 14, 2026

Version Packages (v3) #8099

Merged

		@@ -0,0 +1,176 @@
		import type { HardhatViemHelpers } from "@nomicfoundation/hardhat-viem/types";

Conversation

ChristopherDedominici commented Apr 2, 2026

Uh oh!

changeset-bot Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2026

hardhat

Uh oh!

socket-security Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

alcuadrado Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

ChristopherDedominici Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

alcuadrado Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

ChristopherDedominici Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

alcuadrado left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

changeset-bot Bot commented Apr 2, 2026 •

edited

Loading

socket-security Bot commented Apr 8, 2026 •

edited

Loading