Merged
Conversation
🦋 Changeset detectedLatest commit: d5f8394 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kanej
force-pushed
the
feat/mutex-for-network-handler-setup
branch
from
9d19e54 to
0b74323
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the network hook handler initialization path by avoiding mutex acquisition when request handlers are already cached for a connection, reducing overhead on steady-state request processing.
Changes:
- Refactor
onRequestto use a double-checked lookup aroundAsyncMutex.exclusiveRun. - Add a new test suite covering handler initialization, reuse, per-connection separation, and closeConnection behavior.
- Add a changeset documenting the performance improvement.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/hardhat/src/internal/builtin-plugins/network-manager/hook-handlers/network.ts | Implements double-checked locking to skip the mutex when handlers are already cached. |
| packages/hardhat/test/internal/builtin-plugins/network-manager/hook-handlers/network.ts | Adds tests for initialization/caching behavior (including a concurrent call test). |
| .changeset/forty-groups-bake.md | Records the patch-level performance improvement in release notes. |
kanej
added
no docs needed
kanej
force-pushed
the
feat/mutex-for-network-handler-setup
branch
2 times, most recently
from
cf2aec6 to
41a2c5c
Compare
kanej
force-pushed
the
feat/mutex-for-network-handler-setup
branch
from
41a2c5c to
9f0fadc
Compare
Avoid moving into the Network handler creation mutex, if the handlers already exist.
kanej
force-pushed
the
feat/mutex-for-network-handler-setup
branch
from
9f0fadc to
d5f8394
Compare
alcuadrado
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Network request path we have an expensive initial creation of the request handlers, this creation happens within a mutex.
This PR moves to a double check pattern to avoid moving into the mutex if the handlers have already been set.