feat: replace test lifecycle helpers with hooks#8001
Merged
Conversation
🦋 Changeset detectedLatest commit: 515c622 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alcuadrado
reviewed
Feb 25, 2026
| * @param context The hook context. | ||
| * @param id A string identifier for the test runner (e.g., "solidity", "nodejs", "mocha"). | ||
| */ | ||
| onTestRunStart: (context: HookContext, id: string) => Promise<void>; |
Member
There was a problem hiding this comment.
Let's change these to chained hooks, and always call next() first
This was referenced Feb 28, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the direct helper calls that test runners make into the
coverageandgas-analyticsplugins with test hooks. This decouples the runners from those plugins and is preparatory work for combined gas statistics and support --json output for --gas-stats.This follows the direction explored in #7568.
Summary
markTestRunStart/markTestWorkerDone/markTestRunDonehelper calls withonTestRunStart/onTestWorkerDone/onTestRunDonetest hookscoverage.ts+gas-stats.ts) into a singletest-worker-done.tsto avoid double-firing hooks when both features are enabledhardhat/internal/coverageandhardhat/internal/gas-analyticsexport paths (no longer needed)How it works
Before: Each test runner imported and called helpers from both plugins directly:
After: Each test runner fires a single hook, and plugins respond via registered handlers:
Questions