Skip to content

Conversation

@zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Oct 6, 2025

closes #7053

Updated according to design doc & includes global failure counting as well.

One potential future issue is that the solidity output indentation doesn't match perfectly with the nodejs runner, but that's a minor complaint (and not caused by this update, this update just made it more obvious since we're putting the two outputs next to each other)

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025

🦋 Changeset detected

Latest commit: 7f86a11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nomicfoundation/hardhat-node-test-runner Patch
@nomicfoundation/hardhat-node-test-reporter Patch
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

hardhat

Total size of the bundle: 35M
Total number of dependencies (including transitive): 40

List of dependencies (sorted by size)
29M	total
7.3M	@sentry/core
5.2M	zod
2.7M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@noble/hashes
924K	@nomicfoundation/hardhat-utils
864K	@streamparser/json
624K	micro-packed
592K	tsx
548K	@nomicfoundation/hardhat-errors
492K	@scure/bip39
456K	@nomicfoundation/edr
452K	fast-equals
408K	json-stream-stringify
368K	ethereum-cryptography
332K	@streamparser/json-node
320K	enquirer
320K	@nomicfoundation/hardhat-zod-utils
288K	semver
200K	ws
180K	chokidar
176K	get-tsconfig
168K	@scure/base
160K	esbuild
136K	adm-zip
96K	@scure/bip32
92K	chalk
72K	@nomicfoundation/solidity-analyzer
68K	debug
60K	readdirp
56K	rfdc
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
36K	p-map
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	ms

Copy link
Member

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shared feedback in Slack. I'm submitting the review so this doesn't show up on my list of PRs to check.

@zoeyTM zoeyTM changed the base branch from main to hidden-options October 23, 2025 04:49
@zoeyTM zoeyTM requested a review from fvictorio October 27, 2025 10:35
@fvictorio
Copy link
Member

fvictorio commented Nov 3, 2025

Spacing is slightly broken.

With only a nodejs failure, an empty line is needed:

image

With only a solidity failure, it's fine:

image

When there are failures in both nodejs and solidity, there's a double space between the first and the second error:

image

The last example also shows an inconsistency between the nodejs and solidity outputs that looks a bit ugly to me, but I would consider it out of the scope for this PR. The fix IMO is to change the solidity test output to be 1) contracts/Counter.t.sol:CounterTest:test_initialValue() (maybe using color for contrast)`.

@fvictorio
Copy link
Member

And the CI failures don't look like false negatives to me, unless I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrated test summary between different test tasks

4 participants