-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add summary outputs when multiple test runners are invoked #7514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hidden-options
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7f86a11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hardhatTotal size of the bundle: List of dependencies (sorted by size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shared feedback in Slack. I'm submitting the review so this doesn't show up on my list of PRs to check.
2d8de54 to
7697451
Compare
|
And the CI failures don't look like false negatives to me, unless I'm missing something? |



closes #7053
Updated according to design doc & includes global failure counting as well.
One potential future issue is that the solidity output indentation doesn't match perfectly with the nodejs runner, but that's a minor complaint (and not caused by this update, this update just made it more obvious since we're putting the two outputs next to each other)