Merge user's output selection with our defaults#6668
Merged
Conversation
🦋 Changeset detectedLatest commit: a6c7e85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zoeyTM
force-pushed
the
merge-output-selection
branch
from
77fcdd8 to
971facd
Compare
kanej
reviewed
May 6, 2025
kanej
reviewed
May 6, 2025
| outputSelection["*"]["*"] ??= []; | ||
|
|
||
| outputSelection["*"][""].push("ast"); | ||
| outputSelection["*"]["*"].push( |
Member
There was a problem hiding this comment.
Does it matter that there are duplicates?
Member
There was a problem hiding this comment.
We have opted to defer on this question. If duplicates are a problem we can add explicit removal code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #6551