Skip to content

build: upgrade to @ignored/edr-optimism v0.13.0-alpha.1#6645

Merged
Wodann merged 3 commits intov-nextfrom
build/edr-0.13.0-alpha.1
May 14, 2025
Merged

build: upgrade to @ignored/edr-optimism v0.13.0-alpha.1#6645
Wodann merged 3 commits intov-nextfrom
build/edr-0.13.0-alpha.1

Conversation

@Wodann
Copy link
Member

@Wodann Wodann commented Apr 28, 2025 •
edited
Loading

This PR upgrades @ignored/edr-optimism to v0.13.0-alpha.1, including the following changes:

  • Added instrumenting of source code for statement code coverage measurement
  • Added code coverage to the provider. It can be configured through the ProviderConfig

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Apr 28, 2025
@Wodann Wodann requested review from Copilot and galargh April 28, 2025 23:56
@Wodann Wodann self-assigned this Apr 28, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a849264

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Apr 28, 2025
Copilot AI reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the @ignored/edr-optimism package to v0.13.0-alpha.1 and introduces initial observability configuration for code coverage within the provider.

  • Introduces a new "observability" block in the provider configuration.
  • Adds a placeholder (undefined) for the codeCoverage setting with a TODO to add configurable code coverage options.
Files not reviewed (2)
  • pnpm-lock.yaml: Language not supported
  • v-next/hardhat/package.json: Language not supported

v-next/hardhat/src/internal/builtin-plugins/network-manager/edr/edr-provider.ts
networkId: BigInt(networkConfig.networkId),
observability: {
// TODO: add configuration of code coverage
codeCoverage: undefined,
Copy link

Copilot AI Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codeCoverage property is currently set to undefined. Please consider wiring it to a value from the ProviderConfig or adding a temporary default value so that the configuration is explicitly defined.

Suggested change
codeCoverage: undefined,
codeCoverage: networkConfig.codeCoverage ?? false,

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2025 •
edited
Loading

hardhat

Total size of the bundle: 222M
Total number of dependencies (including transitive): 114

List of dependencies (sorted by size) 
217M	total
24M	@ignored/edr-optimism-linux-x64-musl
24M	@ignored/edr-optimism-linux-x64-gnu
22M	@ignored/edr-optimism-win32-x64-msvc
21M	@ignored/edr-optimism-linux-arm64-musl
21M	@ignored/edr-optimism-linux-arm64-gnu
20M	esbuild
18M	@ignored/edr-optimism-darwin-x64
17M	@ignored/edr-optimism-darwin-arm64
7.7M	@opentelemetry/semantic-conventions
6.2M	@sentry/core
4.2M	@sentry/node
3.1M	@opentelemetry/api
2.5M	micro-eth-signer
2.3M	@opentelemetry/core
1.9M	@opentelemetry/resources
1.9M	@noble/curves
1.7M	undici
1.6M	@opentelemetry/sdk-trace-base
1.2M	@noble/hashes
956K	@opentelemetry/instrumentation
876K	@sentry/opentelemetry
864K	@streamparser/json
860K	@nomicfoundation/hardhat-utils
856K	zod
760K	@opentelemetry/api-logs
684K	import-in-the-middle
624K	resolve
624K	micro-packed
588K	minimatch
584K	tsx
572K	acorn
544K	fast-equals
492K	@scure/bip39
464K	@nomicfoundation/hardhat-errors
408K	json-stream-stringify
368K	ethereum-cryptography
352K	@ignored/edr
332K	@streamparser/json-node
320K	pg-protocol
320K	enquirer
300K	@opentelemetry/instrumentation-http
300K	@ignored/edr-optimism
288K	semver
224K	@opentelemetry/instrumentation-pg
212K	@opentelemetry/instrumentation-graphql
200K	undici-types
196K	ws
188K	@opentelemetry/instrumentation-mongodb
180K	@opentelemetry/instrumentation-undici
176K	@opentelemetry/instrumentation-express
172K	@opentelemetry/instrumentation-amqplib
168K	@scure/base
164K	cjs-module-lexer
156K	@opentelemetry/instrumentation-hapi
148K	@opentelemetry/instrumentation-redis-4
148K	@opentelemetry/instrumentation-mysql
144K	@opentelemetry/instrumentation-fs
136K	get-tsconfig
136K	adm-zip
136K	@opentelemetry/instrumentation-koa
132K	@opentelemetry/instrumentation-knex
124K	@opentelemetry/instrumentation-mongoose
124K	@opentelemetry/instrumentation-ioredis
124K	@fastify/otel
120K	@opentelemetry/instrumentation-mysql2
120K	@opentelemetry/instrumentation-connect
116K	@opentelemetry/instrumentation-kafkajs
112K	@opentelemetry/instrumentation-tedious
112K	@opentelemetry/context-async-hooks
96K	@scure/bip32
96K	@opentelemetry/instrumentation-dataloader
92K	chalk
80K	@opentelemetry/instrumentation-generic-pool
76K	pg-types
76K	@prisma/instrumentation
72K	@nomicfoundation/solidity-analyzer
68K	debug
68K	@opentelemetry/sql-common
68K	@opentelemetry/instrumentation-lru-memoizer
64K	@nomicfoundation/hardhat-zod-utils
60K	acorn-import-attributes
60K	@opentelemetry/redis-common
56K	rfdc
56K	is-core-module
56K	function-bind
52K	@types/tedious
48K	shimmer
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
40K	require-in-the-middle
40K	forwarded-parse
40K	@types/mysql
36K	supports-preserve-symlinks-flag
36K	p-map
36K	@types/pg
32K	hasown
28K	xtend
28K	brace-expansion
24K	strip-ansi
24K	postgres-interval
24K	postgres-array
24K	env-paths
24K	ansi-regex
20K	postgres-date
20K	postgres-bytea
20K	pg-int8
20K	path-parse
20K	ms
20K	module-details-from-path
20K	balanced-match
20K	@types/shimmer
20K	@types/pg-pool
20K	@types/connect

@galargh
Copy link
Contributor

galargh commented Apr 30, 2025

@Wodann Is it OK if we merge this upgrade as-is and later add actual coverage handling on the hardhat side?

@Wodann
Copy link
Member Author

Wodann commented Apr 30, 2025

@Wodann Is it OK if we merge this upgrade as-is and later add actual coverage handling on the hardhat side?

Yeah, if you'd like, it shouldn't break anything.

Would you like me to remove the TODO comment in that case?

@Wodann Wodann marked this pull request as ready for review April 30, 2025 15:20
@Wodann Wodann added this pull request to the merge queue May 14, 2025
Merged via the queue into v-next with commit 54bd672 May 14, 2025
132 checks passed
@Wodann Wodann deleted the build/edr-0.13.0-alpha.1 branch May 14, 2025 08:40
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat May 14, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@galargh galargh galargh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Wodann Wodann

Labels

no changeset needed This PR doesn't require a changeset

Projects

Hardhat
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wodann @galargh