Conversation
🦋 Changeset detectedLatest commit: 62caecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schaable
force-pushed
the
chains-config-refactor
branch
from
c82f1ec to
702a489
Compare
schaable
force-pushed
the
chains-config-refactor
branch
from
32c9558 to
9506fb4
Compare
schaable
commented
May 1, 2025
| ...resolvedConfig, | ||
| chainDescriptors: await resolveChainDescriptors( | ||
| resolvedConfig.chainDescriptors, | ||
| userConfig.chainDescriptors, |
Member
Author
There was a problem hiding this comment.
I’m not sure this is correct, but we’re doing the same thing with the networks. Shouldn’t we always use the resolved version to account for other hook handler changes? Doing so causes type issues, though, since I’d be resolving a field that’s already resolved.
alcuadrado
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6612