Skip to content

Allow undefined for default values in global options and other argument types#6615

Merged
zoeyTM merged 3 commits intov-nextfrom
global-options-default-undefined
May 6, 2025
Merged

Allow undefined for default values in global options and other argument types#6615
zoeyTM merged 3 commits intov-nextfrom
global-options-default-undefined

Conversation

@zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Apr 23, 2025

resolves #6596

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: 1d0bdae

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Apr 23, 2025
@zoeyTM zoeyTM requested a review from alcuadrado April 23, 2025 07:33
@zoeyTM zoeyTM force-pushed the global-options-default-undefined branch from 7720dc9 to d539325 Compare April 23, 2025 07:41
@zoeyTM zoeyTM added the v-next A Hardhat v3 development task label Apr 23, 2025
@zoeyTM zoeyTM force-pushed the global-options-default-undefined branch 3 times, most recently from 6e9f26e to 101208e Compare May 1, 2025 04:12
@zoeyTM zoeyTM force-pushed the global-options-default-undefined branch 2 times, most recently from 32beed4 to 70e2e82 Compare May 5, 2025 09:49
@zoeyTM zoeyTM requested a review from kanej May 6, 2025 09:49
@zoeyTM zoeyTM force-pushed the global-options-default-undefined branch from e6e8125 to 1d0bdae Compare May 6, 2025 09:50
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zoeyTM zoeyTM added this pull request to the merge queue May 6, 2025
Merged via the queue into v-next with commit 34daa32 May 6, 2025
84 checks passed
@zoeyTM zoeyTM deleted the global-options-default-undefined branch May 6, 2025 11:10
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat May 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

v-next A Hardhat v3 development task

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Some GlobalOptions and TaskArguments should be able to have undefined as default value

2 participants