Fix Solidity compilation in subprocesses#6535
Conversation
🦋 Changeset detectedLatest commit: ae7fbc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Inspired (AKA stolen from) NomicFoundation/hardhat-vscode#642 |
alcuadrado
added
no changeset needed
alcuadrado
force-pushed
the
fix-compilation-in-subprocess
branch
from
1c6baaf to
67786e4
Compare
alcuadrado
force-pushed
the
fix-compilation-in-subprocess
branch
from
67786e4 to
15cc50c
Compare
|
|
||
| output = stdout; | ||
| } catch (e: any) { | ||
| throw new HardhatError(ERRORS.SOLC.CANT_RUN_NATIVE_COMPILER, {}, e); |
There was a problem hiding this comment.
Should this be ERRORS.SOLC.SOLCJS_ERROR?
There was a problem hiding this comment.
@alcuadrado I think the error types are swapped between socljs and native implementations 😅
|
Do we have integration tests for this, at least the happy path ? both for running solcjs and native compiler |
Yes, actually, I think we use the compilers too much in integration tests. |
2 participants
This PR modifies the two solidity
ICompilerimplementations, making them more robust.