Skip to content

Prepare for next Node LTS version - branch: main#6497

Merged
ChristopherDedominici merged 17 commits intomainfrom
add-support-node-v23
May 14, 2025
Merged

Prepare for next Node LTS version - branch: main#6497
ChristopherDedominici merged 17 commits intomainfrom
add-support-node-v23

Conversation

@ChristopherDedominici
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici commented Mar 24, 2025 •
edited
Loading

Fixes #6496

Intermediate step: support node v23 while waiting for v24.

Note:
I had to reorganize a few files in ignition because class syntax like private has been replaced with the # prefix.
Example:

private _blockNumber = 10;

becomes:

#blockNumber = 10;

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 811f8b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 10:52am

@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Mar 24, 2025
@ChristopherDedominici ChristopherDedominici linked an issue Mar 24, 2025 that may be closed by this pull request
Prepare for next Node LTS version #6441
Closed
@ChristopherDedominici ChristopherDedominici mentioned this pull request Mar 26, 2025
Closed
ChristopherDedominici
ChristopherDedominici commented May 13, 2025
View reviewed changes
packages/hardhat-solpp/test/tests.ts Outdated
);
});
});
// The test is commented out because otherwise it will fail the test suite in WIndows after the update to node 24
Copy link
Contributor Author

@ChristopherDedominici ChristopherDedominici May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was already skipped, but after the update to Node 24, it somehow caused the entire test suite to fail on Windows. See here: https://github.com/NomicFoundation/hardhat/actions/runs/15000928741/job/42147457507

@ChristopherDedominici ChristopherDedominici marked this pull request as ready for review May 14, 2025 09:06
@ChristopherDedominici ChristopherDedominici moved this from Backlog to In Progress in Hardhat May 14, 2025
@ChristopherDedominici ChristopherDedominici force-pushed the add-support-node-v23 branch 2 times, most recently from ff4e914 to 79d1a17 Compare May 14, 2025 09:23
ChristopherDedominici
ChristopherDedominici commented May 14, 2025
View reviewed changes
packages/hardhat-chai-matchers/test/contracts.ts
import {
BaseContract,
BaseContractMethod,
// eslint-disable-next-line prettier/prettier
Copy link
Contributor Author

@ChristopherDedominici ChristopherDedominici May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed because otherwise the lint task will fail

ChristopherDedominici
ChristopherDedominici commented May 14, 2025
View reviewed changes
alcuadrado
alcuadrado reviewed May 14, 2025
View reviewed changes
alcuadrado
alcuadrado reviewed May 14, 2025
View reviewed changes
alcuadrado
alcuadrado approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #private thing is unexpected, but ok.

I left a small comment. Apart from that, it looks ready.

ChristopherDedominici and others added 2 commits May 14, 2025 14:23
@ChristopherDedominici @alcuadrado
Update packages/hardhat-core/src/internal/cli/constants.ts
efbf23d 
Co-authored-by: Patricio Palladino <email@patriciopalladino.com>
@ChristopherDedominici
still support v 18
811f8b6
@ChristopherDedominici ChristopherDedominici merged commit a8ad44c into main May 14, 2025
127 checks passed
@ChristopherDedominici ChristopherDedominici deleted the add-support-node-v23 branch May 14, 2025 14:00
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hardhat May 14, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@kanej kanej

Labels

None yet

Projects

Hardhat
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prepare for next Node LTS version

3 participants

@ChristopherDedominici @alcuadrado @kanej