Prevent losing typechain types when compiling a subset of contracts#6458
Prevent losing typechain types when compiling a subset of contracts#6458
Conversation
🦋 Changeset detectedLatest commit: dd31e81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6b0283b to
f7e49db
Compare
f7e49db to
bc3bd6a
Compare
bc3bd6a to
dd31e81
Compare
|
Cool solution, I like it! @alcuadrado wdyt? |
I've checked typechain-ethers and there's no option to "merge" newly added artifacts into an existing type file (hardhat.d.ts). It just uses whatever is passed on allArtifacts |
|
I think this PR was replaced by the (just merged) #6400 |
@alcuadrado @antico5 In the current version of So these 2 PRs are addressing different issues. @antico5 You do have merge conflicts, though, because the hook used has changed |
|
I am closing this as we need to rethink our approach after the changes to partial recompilation. |
When compiling a subset of contracts, only the generated artifacts were being passed to typechain, losing the types of any previously generated artifacts.
This PR changes that, so besides passing the current generated artifacts, it passes all available artifacts in the project.
I had to adapt the test cases a bit since apparently on windows the generated files have a different directory structure than in linux/mac when having multiple contracts.
Closes #6311