chore: bump EDR to 0.8.0 #6203
Merged
chore: bump EDR to 0.8.0 #6203
+48
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: edb1490 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agostbiro
reviewed
Jan 31, 2025
| try { | ||
| for (const buildInfoFile of buildInfoFiles) { | ||
| const buildInfo = await fsExtra.readJson(buildInfoFile); | ||
| if (semver.gte(buildInfo.solcVersion, FIRST_SOLC_VERSION_SUPPORTED)) { |
There was a problem hiding this comment.
kanej
reviewed
Jan 31, 2025
| config: HardhatNetworkProviderConfig, | ||
| loggerConfig: LoggerConfig, | ||
| tracingConfig?: TracingConfig | ||
| tracingConfig?: TracingConfigWithBuffers |
There was a problem hiding this comment.
I was initially worried about this move as it is changing the API, but EdrProviderWrapper is in internal and is not exposed to the user. The only place create is invoked, uses makeTracingConfig which has had its return type altered as well.
Put another way this signature change looks safe to me.
kanej
approved these changes
Jan 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump EDR to 0.8.0.
This fixes the following issues:
Minor Changes
Patch Changes