feat: adopt EDR multichain #6120
Conversation
🦋 Changeset detectedLatest commit: a9e020c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alcuadrado
added
v-next
Wodann
force-pushed
the
feat/multichain
branch
from
f9e4daa to
f07a6f7
Compare
Wodann
force-pushed
the
feat/multichain
branch
from
640c6d2 to
2e98d7d
Compare
Wodann
force-pushed
the
feat/multichain
branch
from
2e98d7d to
83d0c45
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| } | ||
|
|
||
| let returnValue = rpcDebugTrace.output?.toString("hex") ?? ""; | ||
| let returnValue = rpcDebugTrace.output?.toString() ?? ""; |
There was a problem hiding this comment.
This chnge surprised me because it looks wrong but it actually works fine.
Why it looks wrong: the type of rpcDebugTrace.output is allegedly Uint8Array (see here). But the .toString method of Uint8Array does not format the result in hexadecimal.
Why it works: the actual value received here is a string. Calling .toString on a string just returns the same value. That string is already a hex representation of the output.
This is not a blocker, but seems worth investigating. Why is EDR's index.d.ts wrong?
This PR tracks changes needed to backport EDR's multi-chain architecture to Hardhat 2.
After merging this PR, Hardhat will no longer support
smock, as per the maintainer's own archival of the repo.