Skip to content

refactor: remove smock integration tests due to deprecation#1255

Merged
Wodann merged 3 commits intomainfrom
refactor/remove-smock-tests
Jan 6, 2026
Merged

refactor: remove smock integration tests due to deprecation#1255
Wodann merged 3 commits intomainfrom
refactor/remove-smock-tests

Conversation

@Wodann
Copy link
Member

@Wodann Wodann commented Jan 5, 2026

smock has been deprecated. As such, we have already stopped supporting smock in the latest Hardhat 2. This PR removes the integration tests for smock from EDR's codebase too.

@Wodann Wodann requested review from a team and Copilot January 5, 2026 15:24
@Wodann Wodann self-assigned this Jan 5, 2026
@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Jan 5, 2026
@Wodann Wodann temporarily deployed to github-action-benchmark January 5, 2026 15:24 — with GitHub Actions Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

⚠️ No Changeset found

Latest commit: 4d66094

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the integration tests for smock, a deprecated mocking library that is no longer supported in Hardhat 2. The changes clean up the test infrastructure by removing all smock-related test files and configuration.

  • Removes the smock integration test directory and all associated files
  • Eliminates dependencies on the deprecated @defi-wonderland/smock package
  • Cleans up .gitignore entries specific to the smock integration tests

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hardhat-tests/integration/smock/test/test.js Removes the smock integration test file containing mock contract testing logic
hardhat-tests/integration/smock/package.json Removes package configuration including smock and related dependencies
hardhat-tests/integration/smock/hardhat.config.js Removes Hardhat configuration file for smock tests
hardhat-tests/integration/smock/contracts/FooBar.sol Removes Solidity contracts used for smock testing
hardhat-tests/integration/.gitignore Removes .gitignore file for integration test artifacts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.25%. Comparing base (8c1d0b4) to head (4d66094).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files         436      436           
  Lines       74168    74168           
  Branches    74168    74168           
=======================================
  Hits        54330    54330           
  Misses      17842    17842           
  Partials     1996     1996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wodann Wodann temporarily deployed to github-action-benchmark January 5, 2026 15:40 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark January 5, 2026 15:40 — with GitHub Actions Inactive
Copy link
Contributor

@anaPerezGhiglia anaPerezGhiglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run-integration-tests.sh file should be deleted as well and the hardhat-tests/package.json should be updated accordingly.
I think we can remove test:ci script from package.json as well, now that it will be identical to test script. If we do so, hardhat-tests.yml github workflow should be updated as well

@Wodann Wodann had a problem deploying to github-action-benchmark January 6, 2026 18:07 — with GitHub Actions Error
@Wodann
Copy link
Member Author

Wodann commented Jan 6, 2026

run-integration-tests.sh file should be deleted as well and the hardhat-tests/package.json should be updated accordingly. I think we can remove test:ci script from package.json as well, now that it will be identical to test script. If we do so, hardhat-tests.yml github workflow should be updated as well

Thanks for catching that!

Addressed by be59566

@Wodann Wodann requested a review from anaPerezGhiglia January 6, 2026 18:08
@Wodann Wodann temporarily deployed to github-action-benchmark January 6, 2026 18:08 — with GitHub Actions Inactive
@Wodann Wodann had a problem deploying to github-action-benchmark January 6, 2026 18:12 — with GitHub Actions Failure
@Wodann Wodann temporarily deployed to github-action-benchmark January 6, 2026 18:12 — with GitHub Actions Inactive
@Wodann Wodann added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 139613c Jan 6, 2026
50 of 51 checks passed
@Wodann Wodann deleted the refactor/remove-smock-tests branch January 6, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed This PR doesn't require a changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants