refactor: remove smock integration tests due to deprecation#1255
refactor: remove smock integration tests due to deprecation#1255
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR removes the integration tests for smock, a deprecated mocking library that is no longer supported in Hardhat 2. The changes clean up the test infrastructure by removing all smock-related test files and configuration.
- Removes the smock integration test directory and all associated files
- Eliminates dependencies on the deprecated
@defi-wonderland/smockpackage - Cleans up .gitignore entries specific to the smock integration tests
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hardhat-tests/integration/smock/test/test.js | Removes the smock integration test file containing mock contract testing logic |
| hardhat-tests/integration/smock/package.json | Removes package configuration including smock and related dependencies |
| hardhat-tests/integration/smock/hardhat.config.js | Removes Hardhat configuration file for smock tests |
| hardhat-tests/integration/smock/contracts/FooBar.sol | Removes Solidity contracts used for smock testing |
| hardhat-tests/integration/.gitignore | Removes .gitignore file for integration test artifacts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 73.25% 73.25%
=======================================
Files 436 436
Lines 74168 74168
Branches 74168 74168
=======================================
Hits 54330 54330
Misses 17842 17842
Partials 1996 1996 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anaPerezGhiglia
left a comment
There was a problem hiding this comment.
run-integration-tests.sh file should be deleted as well and the hardhat-tests/package.json should be updated accordingly.
I think we can remove test:ci script from package.json as well, now that it will be identical to test script. If we do so, hardhat-tests.yml github workflow should be updated as well
Thanks for catching that! Addressed by be59566 |
smockhas been deprecated. As such, we have already stopped supportingsmockin the latest Hardhat 2. This PR removes the integration tests forsmockfrom EDR's codebase too.