horizon-eda: init at 1.2.1#99964
Merged
JohnAZoidberg merged 1 commit intoNixOS:masterfrom Oct 10, 2020
Merged
Conversation
JohnAZoidberg
approved these changes
Oct 9, 2020
Member
JohnAZoidberg
left a comment
JohnAZoidberg
left a comment
There was a problem hiding this comment.
Looks good. Just some minor suggestions :)
guserav
force-pushed
the
horizon-eda
branch
2 times, most recently
from
e179189 to
55b71e2
Compare
Member
|
Evaluation failure on OfBorg is unrelated. See #100089 (comment) Tested on NixOS and seems to work fine. |
Mostly based on NixOS#86694 by yrashk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly based on #86694 by yrashk
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)